Autodesk: Feature hgi vulkan unit test #2851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 8302b97cafa6de6d43e2dad12efe4717ade4f327)
…ugin (cherry picked from commit c0fa5e90e4f22aa08d441a10b8fd5c4798be3598)
|
Filed as internal issue #USD-9059 |
clach
reviewed
Dec 12, 2023
| @@ -41,7 +41,7 @@ class HdStormRendererPlugin final : public HdRendererPlugin { | |||
| virtual void DeleteRenderDelegate(HdRenderDelegate *renderDelegate) | |||
| override; | |||
|
|
|||
| virtual bool IsSupported(bool gpuEnabled = true) const override; | |||
| virtual bool IsSupported(bool gpuEnabled = true, TfToken token = TfToken("")) const override; | |||
There was a problem hiding this comment.
I believe this change is supposed to be in PR #2850.
There was a problem hiding this comment.
This bit is needed for successful runtime checking of HgiVulkan support. The default for the platform remains to be OpenGL (if no Vulkan token is passed). Otherwise the Vulkan backend get initialized.
clach
merged commit ab7c953
into
PixarAnimationStudios:feature-hgi-vulkan
1 of 5 checks passed
pixar-oss
pushed a commit
that referenced
this pull request
Jun 11, 2024
Fixes #2851 (Internal change: 2330271)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change(s)
This PR provides a functioning unit test to test pipeline creation and draw command execution of Hgi.
For this test, a hgi backend of HgiVulkan is selected. The generated output is compared to a baseline image.
Fixes Issue(s)