Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing unneeded trailing zero from sdf max units expression #2810

Merged
merged 1 commit into from
Nov 28, 2023

Conversation

nvmkuruc
Copy link
Collaborator

Description of Change(s)

#2590 replaced some preprocessor expressions with a constexpr use of std::max to compute the maximum number of units. std::max takes an initializer list populated by a macro that appends a , after each element.

The original implementation added 0 to follow the last ,. However, as std::initializer_lists are allowed to have trailing commas, this was unneeded.

Fixes Issue(s)

  • I have verified that all unit tests pass with the proposed changes
  • I have submitted a signed Contributor License Agreement

@jesschimein
Copy link
Collaborator

Filed as internal issue #USD-8953

@pixar-oss pixar-oss merged commit 89ce625 into PixarAnimationStudios:dev Nov 28, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants