Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an iterator to tf to decode UTF-8 strings #2788

Merged
merged 1 commit into from
Nov 17, 2023

Conversation

nvmkuruc
Copy link
Collaborator

@nvmkuruc nvmkuruc commented Nov 6, 2023

Description of Change(s)

#2687 will be introducing support for identifying code points in the Xid unicode class. This foundational change adds Utf8CodePointIterator and Utf8CodePointView to convert UTF-8 encoded strings to code points.

Fixes Issue(s)

  • I have verified that all unit tests pass with the proposed changes
  • I have submitted a signed Contributor License Agreement

@nvmkuruc nvmkuruc force-pushed the utfiterator branch 4 times, most recently from cf438d6 to 1bbb830 Compare November 6, 2023 22:15
@jesschimein
Copy link
Collaborator

Filed as internal issue #USD-8914

@nvmkuruc nvmkuruc force-pushed the utfiterator branch 3 times, most recently from 4d0e644 to b83e289 Compare November 9, 2023 18:20
@crevilla
Copy link

crevilla commented Nov 9, 2023

With the making of the IsPastTheEnd and the constructor private, this is good to me

@pixar-oss pixar-oss merged commit 7cd9329 into PixarAnimationStudios:dev Nov 17, 2023
3 of 5 checks passed
pixar-oss added a commit that referenced this pull request Nov 17, 2023
…to have the Tf library prefix as per our normal conventions.

Fixes #2788

(Internal change: 2304686)
@nvmkuruc nvmkuruc deleted the utfiterator branch May 20, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants