Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add locale independent TfStringToLowerAscii #2751

Merged
merged 1 commit into from
Nov 1, 2023

Conversation

nvmkuruc
Copy link
Collaborator

@nvmkuruc nvmkuruc commented Oct 20, 2023

Description of Change(s)

To more robustly support UTF-8 encoding of strings, this promotes a utility function from fileFormatRegistry.cpp used for locale independent case folding to pixar/base/tf/stringUtils.h as TfStringToLowerAscii. This will replace TfStringToLower in many cases where one of the strings is known to be ASCII (or UTF-8 where a specification explicitly callouts of only casefolding of [A-Z]).

Fixes Issue(s)

  • I have verified that all unit tests pass with the proposed changes
  • I have submitted a signed Contributor License Agreement

@jesschimein
Copy link
Collaborator

Filed as internal issue #USD-8862

@pixar-oss pixar-oss merged commit 5f42eb5 into PixarAnimationStudios:dev Nov 1, 2023
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants