Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace boost::variant with std::variant in usdGeom #2710

Merged
merged 1 commit into from
Oct 2, 2023
Merged

Replace boost::variant with std::variant in usdGeom #2710

merged 1 commit into from
Oct 2, 2023

Conversation

nvmkuruc
Copy link
Collaborator

Description of Change(s)

Replace boost::variant, boost::apply_visitor, and boost::get with std::variant, std::visit, and std::get. It also removes boost::static_visitor as its not needed for std::variant.

Fixes Issue(s)

  • I have verified that all unit tests pass with the proposed changes
  • I have submitted a signed Contributor License Agreement

@nvmkuruc nvmkuruc changed the title Replace boost::optional with std::optional in usdGeom Replace boost::variant with std::variant in usdGeom Sep 18, 2023
@jesschimein
Copy link
Collaborator

Filed as internal issue #USD-8726

@nvmkuruc nvmkuruc force-pushed the usdgeomvariant branch 2 times, most recently from a419b48 to 6c713c8 Compare September 19, 2023 19:13
@pixar-oss pixar-oss merged commit 892c9e9 into PixarAnimationStudios:dev Oct 2, 2023
5 checks passed
@nvmkuruc nvmkuruc deleted the usdgeomvariant branch December 29, 2023 03:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nvmkuruc @jesschimein @pixar-oss