Autodesk: Cache materialX::LoadLibraries step to be done once #2666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…read safe singleton class
|
Filed as internal issue #USD-8673 |
|
Tagging @klucknav for visibility |
pixar-oss
pushed a commit
that referenced
this pull request
Nov 28, 2023
This change is based on github pull request #2666 (Internal change: 2306433)
|
Hi @jesschimein @klucknav or is there another person I should tag? Any update on this PR? We've a shipping product that's looking to incorporate this work. Let us know if there's anything on our end we can do to help this along. Maybe we can get some feedback on this before addressing the new merge conflicts? |
|
A change based on this PR has already been incorporated in the dev branch and will be a part of the 24.03 release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change(s)
Cache the materialX::LoadLibraries step to be done once. Use pxr's thread safe singleton class.
When processing hdMaterialNetwork for Materialx, the mx::loadLibraries step could be done once and cached. This step improves performance when applying MaterialX shader networks on prims. We use pxr's thread-safe singleton class to do the loadLibraries step once.
Fixes Issue(s)