Replace boost::call_traits in pxr/usd/sdf/accessorHelpers.h
#2527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crevilla
reviewed
Jul 8, 2023
| @@ -173,6 +173,13 @@ SDF_ACCESSOR_CLASS::name_( \ | |||
|
|
|||
| // Convenience macros to provide common combinations of value accessors | |||
|
|
|||
There was a problem hiding this comment.
Okay, so I think we could make this more complete by adding to the conditional by making it
std::Is_arithmetic::value || std::is_enum::value
All the places I see that use the SDF_DEFINE_TYPED_GET_SET macro are specifically to for enum values which leads me to believe enums were a hole in the original boost call_traits.
However, I'm okay with leaving this as is in your change and following a followup bug to add is_enum and replace the SDF_DEFINED_TYPED_GET_SET usages
|
Filed as internal issue #USD-8484 |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change(s)
The macros in
pxr/usd/sdf/accessorHelpers.huseboost::call_traitsto convert the parameterTtoconst TifTis a primitive type and the cost of the reference outweighs the cost of the copy (const T&otherwise).This replaces that macro with a templated
usingstatement and standard STL traits.Fixes Issue(s)