Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revise removal of boost::compressed_pair to better preserve object layout #2522

Merged
merged 1 commit into from
Jul 27, 2023

Conversation

nvmkuruc
Copy link
Collaborator

@nvmkuruc nvmkuruc commented Jul 3, 2023

Description of Change(s)

Some minor performance regressions were observed in the initial removal of boost::compressed_pair (#2259) . This PR restores the order of inheritance of the equality and hash function objects which were inadvertently switched as well as some of the original initialization logic.

Fixes Issue(s)

  • I have verified that all unit tests pass with the proposed changes
  • I have submitted a signed Contributor License Agreement

@jesschimein
Copy link
Collaborator

Filed as internal issue #USD-8477

@pixar-oss pixar-oss merged commit 5f23c4c into PixarAnimationStudios:dev Jul 27, 2023
@nvmkuruc nvmkuruc deleted the tfcompressedpair branch December 29, 2023 03:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants