Autodesk: Fix bug where Creation of HgiGLSampler will always set GL_TEXTURE_MAX_ANISOTROPY_EXT to 16 #2492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_ANISOTROPY_EXT to 16. In the constructor of HgiGLSampler, we will check if the minFilter or magFilter is nearest. If yes, we will not set GL_TEXTURE_MAX_ANISOTROPY_EXT. When GL_TEXTURE_MAX_ANISOTROPY_EXT is set, it will ignore the minFilter and magFilter on some platform. This means that we will never create a nearest sampler. Formatting
|
Filed as internal issue #USD-8424 |
pixar-oss
pushed a commit
that referenced
this pull request
Nov 1, 2023
anisotropy when the min or mag filter is nearest, matching the GL version (as done in change 2300291). Fixes #2492 (Internal change: 2300652)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change(s)
HgiGLSampler will always enable ANISOTROPY. But when the filter is nearest, we should disable anisotropy. In this branch we fix this issue. In the constructor of HgiGLSampler, we will check if the minFilter or magFilter is nearest. If yes, we will not set GL_TEXTURE_MAX_ANISOTROPY_EXT. When GL_TEXTURE_MAX_ANISOTROPY_EXT is set, it will ignore the minFilter and magFilter on some platform. This means that we will never create a nearest sampler.
Fixes Issue(s)