Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

APPLE: Keep the color target as an FP16 format in hgiInterop #2482

Conversation

creijon
Copy link
Contributor

@creijon creijon commented Jun 8, 2023

Description of Change(s)

Keep the colour target as an FP16 in HgiInteropMetal, which allows openGL clients to use EDR. This doesn't change the behaviour in usdview, we'll have to add some changes into the Python code to create the right final target.

Fixes Issue(s)

  • I have verified that all unit tests pass with the proposed changes
  • I have submitted a signed Contributor License Agreement

@jesschimein
Copy link
Collaborator

Filed as internal issue #USD-8412

pixar-oss pushed a commit that referenced this pull request Jun 21, 2023
Keep the colour target as an FP16 in HgiInteropMetal, which allows openGL clients to use EDR.  This doesn't change the behaviour in usdview, we'll have to add some changes into the Python code to create the right final target.

Contribution: Apple

Fixes #2482

(Internal change: 2281903)
@sunyab
Copy link
Contributor

sunyab commented Jun 21, 2023

This PR was merged into the dev branch in 075fc26.

@sunyab sunyab closed this Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants