APPLE: Move ResolveCullMode to geometry shader and remove accessors. #2433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Filed as internal issue #USD-8317 |
creijon
force-pushed
the
jon/dev/geometry_shader_cullstate
branch
from
d0ba8e4 to
996ce58
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change(s)
The
_ResolveCullModemethod inhdSt/renderPassState.cpprequires a number of accessors on theHdSt_GeometricShader, specifically:GetCullStyleGetUseHardwareFaceCullingGetHasMirroredTransformGetDoubleSidedIt seems to make more sense to move this function into the geometric shader and remove these accessors entirely.
Fixes Issue(s)