Register velocities, acclerations, and local constant-interpolation primvars on PIs #1734
Conversation
…rimvars on point instancer primitives as hydra-accessible primvars. Otherwise instancer-level settings applied as primvars can't be accessed by the delegate, and constant-interpolation primvars can't be used to affect prototypes marked as instanceable (where inheriting primvars doesn't work).
|
Filed as internal issue #USD-7112 |
- Fixed typo causing testUsdViewMaterialEdits to fail. - Fixed failure tolerance on testUsdImagingGLDomeLight_multi to avoid conflicts with perceptual diff as done in other perceptual diff tests. On our internal test machine, there are multiple pixel differences but no perceptual differences. - Fixed missing install of Embree-related test assets that caused test failures. - Changed several Embree test settings, primarily to use perceptual diffs instead of pixel diffs. - Disabled testUsdviewLegacyImpl. This test is failing on an internal test machine and needs to be investigated. - Disabled testusdview/usdImagingGL tests on Windows due to intermittent hangs that need to be investigated (Internal change: 2217839)
|
For both constant primvars (here) and inherited primvars (in the other PR), you're changing the hydra schema in a way where we'll need to fix up our backends to now pull constant instancer data, which makes it harder to land. Is it possible to get just velocities and accelerations by themselves? |
|
I can certainly split outhe vel/accel parts of this PR into a separate reduced version of this PR. I'm not sure I see the downside to exposing the constant interp primvars though. If a given render delegate doesn't want to look at these values, it doesn't have to, and its behavior will continue to be the same as if hydra wasn't reporting these primvars. Anyway, I'll create the PR once the 22.05 dust settles a bit. I'll be busy upgrading for the next little while. |
Description of Change(s)
Register velocities, acclerations, and local constant-interpolation primvars
on point instancer primitives as hydra-accessible primvars. Otherwise
instancer-level settings applied as primvars can't be accessed by the
delegate, and constant-interpolation primvars can't be used to affect
prototypes marked as instanceable (where inheriting primvars doesn't
work).
This is a less ambitious version of #1731, which additoinally adds support for inherited primvars.