Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hydra can't open tx textures #97

Closed
sirpalee opened this issue Nov 2, 2016 · 7 comments
Closed

Hydra can't open tx textures #97

sirpalee opened this issue Nov 2, 2016 · 7 comments

Comments

@sirpalee
Copy link
Contributor

sirpalee commented Nov 2, 2016

Hydra can't open tx textures. It's commonly used, so it might be a good idea just to enable it. It's just adding the tx extension to the supported formats by Glf_OIIOImage.


---
 pxr/imaging/lib/glf/plugInfo.json | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/pxr/imaging/lib/glf/plugInfo.json b/pxr/imaging/lib/glf/plugInfo.json
index ce86c17..bb5a20f 100644
--- a/pxr/imaging/lib/glf/plugInfo.json
+++ b/pxr/imaging/lib/glf/plugInfo.json
@@ -6,7 +6,7 @@
                 "Types": {                                                                  
                     "Glf_OIIOImage" : {
                         "bases": ["GlfImage"],
-                        "imageTypes": ["bmp", "exr", "jpg", "png", "tif", "zfile"],
+                        "imageTypes": ["bmp", "exr", "jpg", "png", "tif", "zfile", "tx"],
                         "precedence": 0
                     },
                     "GlfPtexTexture" : {
-- 
2.7.4
@sirpalee sirpalee changed the title Hydra can' Hydra can't open tx textures Nov 2, 2016
@jtran56
Copy link

jtran56 commented Nov 2, 2016

Filed as internal issue #139514.

@meshula
Copy link
Member

meshula commented Nov 3, 2016

This one is interesting. Wouldn't it make sense for glf to ask the linked OIIO for a list of readable imageTypes, instead of hard coding it in the plugInfo.json file?

@sirpalee
Copy link
Contributor Author

sirpalee commented Nov 3, 2016

@meshula Right now hydra doesn't support all the data kinds that oiio does (like field3d), and also ptex is implemented in a separate class. So you'll end up manually specifying the formats you are interested in (or excluding some of them), like now.

@meshula
Copy link
Member

meshula commented Nov 3, 2016

Makes sense. Thanks

@c64kernal
Copy link
Contributor

Thanks yeah -- and there's a bit of a chicken and egg problem where OIIO is implemented as a "plugin" in our system that we would (in theory) avoid loading altogether until we knew we needed it (based on matching manually listed extensions in the plugInfo file). However, for now that isn't being taken advantage of, of course, hence the word plugin in quotes :)

@davidgyu
Copy link
Member

One bit of confusion is that both ".tx" and ".tex" filename extensions have been used to designate files created by prman's 'txmake' using prman's proprietary texture image format. OIIO has support for ".tx" files compatible with OIIO's 'maketx'.

We use additional glfImage plugins within the studio to load proprietary prman texture image files registered for both ".tx" and ".tex" extensions.

We should be able to support both and make sure that we can load all of the compatible formats supported by the local OIIO installation. Taking a look...

@sunyab
Copy link
Contributor

sunyab commented May 30, 2018

This was fixed by pull request #467, which was merged and released in 0.8.5. Closing this out, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants