Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmake drops opensubdiv defines intended for Hd #33

Closed
asluk opened this issue Aug 26, 2016 · 2 comments
Closed

cmake drops opensubdiv defines intended for Hd #33

asluk opened this issue Aug 26, 2016 · 2 comments

Comments

@asluk
Copy link
Collaborator

asluk commented Aug 26, 2016

This is because the CMakeLists for Hd is using _add_define(), the effects of which have already been applied by the time individual libraries are reached, instead of add_definitions().

https://github.com/PixarAnimationStudios/USD/blob/2eb01f5cd4c2dae4e1ef9912ca27a93083bb6ef4/pxr/imaging/lib/hd/CMakeLists.txt#L10

I have a fix.
@asluk asluk mentioned this issue Aug 26, 2016
Merged
@jtran56
Copy link

jtran56 commented Aug 26, 2016

Filed as internal issue #136468.

@sunyab
Copy link
Contributor

sunyab commented Sep 23, 2016

This change has been merged into the latest 0.7.1 release. Closing, thanks!

@sunyab sunyab closed this as completed Sep 23, 2016
@alexwheezy alexwheezy mentioned this issue Jun 19, 2017
Closed
@asluk asluk mentioned this issue May 8, 2019
Closed
@Felix-Kit Felix-Kit mentioned this issue Feb 9, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@asluk @sunyab @jtran56