Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

USD bakes full SDK path to INTERFACE_LINK_LIBRARIES in pxrTargets.cmake #2771

Open
dgovil opened this issue Oct 31, 2023 · 2 comments
Open

Comments

@dgovil
Copy link
Collaborator

dgovil commented Oct 31, 2023

pxrTargets.cmake bakes in the full path to an SDK library during the build which means that the final build isn't portable to build other stuff against unless all the machines have the same SDK versions available.

Unfortunately that means that if someone upgrades their OS, they won't have the same SDK versions available, and will therefore be unable to compile without modifying the targets file.

It would be great if USD used generic linkage for system libs instead of exact SDK versions

e.g

set_target_properties(arch PROPERTIES
  INTERFACE_INCLUDE_DIRECTORIES "${_IMPORT_PREFIX}/include"
  INTERFACE_LINK_LIBRARIES "/Library/Developer/CommandLineTools/SDKs/MacOSX13.5.sdk/usr/lib/libm.tbd"
)
set_target_properties(garch PROPERTIES
  INTERFACE_LINK_LIBRARIES "arch;tf;/Library/Developer/CommandLineTools/SDKs/MacOSX13.5.sdk/System/Library/Frameworks/OpenGL.framework;/Library/Developer/CommandLineTools/SDKs/MacOSX13.5.sdk/System/Library/Frameworks/AppKit.framework"

)
@jesschimein
Copy link
Contributor

Filed as internal issue #USD-8891

@dgovil
Copy link
Collaborator Author

dgovil commented Oct 31, 2023

Put up a PR for this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants