Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preprocessor usage can be reduced in pxr/base/tf #2318

Closed
nvmkuruc opened this issue Mar 1, 2023 · 3 comments
Closed

Preprocessor usage can be reduced in pxr/base/tf #2318

nvmkuruc opened this issue Mar 1, 2023 · 3 comments

Comments

@nvmkuruc
Copy link
Collaborator

nvmkuruc commented Mar 1, 2023

Description of Issue

Both pxr/base/tf/enum.h and pxr/base/tf/scopeDescription.h provide macros which use the boost preprocessor.

The enum.h usage can be removed in favor of always passing a string since the default argument is an empty string.
The scopeDescription.h usage can be removed in favor of variadic templates. Specific forwarding overloads can be provided to avoid unnecessarily creating new strings if no formatting is needed.

Steps to Reproduce

N/A

System Information (OS, Hardware)

N/A

Package Versions

N/A

Build Flags

N/A

@nvmkuruc
Copy link
Collaborator Author

nvmkuruc commented Mar 1, 2023

I have a fix.

@tallytalwar
Copy link
Contributor

Filed as internal issue #USD-8066

@nvmkuruc
Copy link
Collaborator Author

This was addressed by #2320. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants