Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pxr/usd/usd/crateFile.{h,cpp} can use robin_map instead of boost::container::flat_map #2296

Closed
nvmkuruc opened this issue Feb 17, 2023 · 3 comments

Comments

@nvmkuruc
Copy link
Collaborator

Description of Issue

CrateFile uses boost::flat_map to record a registry of type specific functions and a time code ordered list of values.

The first usage does not rely on the order of boost::flat_map and be replaced directly with robin_map.

The second usage requires an addition sort of the keys / iterators after the map has been populated.

Steps to Reproduce

N/A

System Information (OS, Hardware)

N/A

Package Versions

N/A

Build Flags

N/A

@nvmkuruc
Copy link
Collaborator Author

I have a fix.

@nvmkuruc nvmkuruc changed the title pxr/usd/usd/crateFile.{h,cpp} can use robin_map instead of boost::flat_map pxr/usd/usd/crateFile.{h,cpp} can use robin_map instead of boost::container::flat_map Feb 17, 2023
@tallytalwar
Copy link
Contributor

Filed as internal issue #USD-8037

@nvmkuruc
Copy link
Collaborator Author

This was addressed by #2297 and can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants