_close crashes on windows 10

[helgemathee]

Description of Issue

When running USD on windows 10 there is a crash in atomicOfStreamWrapper and possibly other places calling _close on a temporary file. the use of _sopen_s and _close seems to be causing crashes on Windows 10, Visual Studio 2015.

I've tested using GetTempFileName instead (see attached patch) and that works.
fileSystem.cpp.txt

Steps to Reproduce

1. Build on Windows 10, Visual Studio 2015
2. try to create a stage in C++

System Information (OS, Hardware)

Windows 10, Visual Studio 2015

Package Versions

latest dev branch

Build Flags

[jtran56]

Filed as internal issue #144797.

[sunyab]

Hi @helgemathee, we haven't seen this in any of our local testing here -- any chance you could send us a stack trace of the crash? Thanks!

[helgemathee]

helloworld.zip

here's a minimalistic repro - you can use scons or just build the arch into a dll and the main into an exe - it crashes during execution.

I'll dig a bit deeper today and will keep you posted - also with a stacktrace.

[helgemathee]

so this was related to two runtimes fighting - linking with /MT on windows causes this issue. closing.