Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved osd patch drawing compatibility #1320

Merged
merged 2 commits into from
Sep 14, 2023
Merged

Improved osd patch drawing compatibility #1320

merged 2 commits into from
Sep 14, 2023

Commits on Sep 13, 2023

  1. Reorganized legacy patch drawing shader source 

    Relocated from PatchCommon to PatchLegacy several aspects of the
shader source which can cause problems with typical use cases.
Specifically, things like resource bindings, input assembler and
interstage declarations are best left to client code.

These are not removed, just relocated and remain available for
backward compatibility. Updated the GLSL, HLSL, and MSL source.
    @davidgyu
    davidgyu committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    c2ed7d5 View commit details
    Browse the repository at this point in the history

  2. Added GetPatchDrawingShaderSource() 

    This is a new method for GLSL, HLSL, and MSL which returns patch
drawing shader source which excludes legacy shader source aspects.

This improves portability and compatibility and may also improve
shader compile times since the resulting shader source strings
are smaller without the legacy shader source aspects.

Tested with Vulkan and DX12 in addition to GL, DX11, and Metal.
    @davidgyu
    davidgyu committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    fdb9ac9 View commit details
    Browse the repository at this point in the history