Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turning on rounding causes discrepancy between weather card and sensors #177

Closed
7 tasks done
cloneofghosts opened this issue Jan 17, 2024 · 1 comment · Fixed by #187
Closed
7 tasks done

Turning on rounding causes discrepancy between weather card and sensors #177

cloneofghosts opened this issue Jan 17, 2024 · 1 comment · Fixed by #187
Assignees
Labels
bug Something isn't working Needs Review

Comments

@cloneofghosts
Copy link
Collaborator

Describe the bug

I noticed that when I have rounding enabled in the options that it causes a discrepancy between the wind speed values displayed in the weather card versus what is displayed in the sensor. If rounding is disabled then then the wind speed values match up between the sensor and the card.

Expected behavior

The wind speed should be the same regardless of if rounding is enabled or not.

Actual behavior

Having rounding enabled causes the wind speed between the card and the sensors to differ.

Home Assistant version

2024.1.3

Integration version

1.4

Other details

While I'm not 100% sure how the conversion works for the weather card but it seems like its rounding the value first and then converting it to your local units.

Troubleshooting steps

  • I have updated my Home Assistant installation to the latest version.
  • I have updated the Pirate Weather Integration to the latest version.
  • I have gone through the documentation, parameter documentation and sensor documentation before opening this issue.
  • I have searched this repository and Pirate Weather Repository to see if the issue has already been reported.
  • I have restarted my Home Assistant installation.
  • I have checked to see if the issue is not an API issue.
  • I have written an informative title.
@cloneofghosts
Copy link
Collaborator Author

cloneofghosts commented Jan 25, 2024

@alexander0042 Is HA responsible for converting the units from the provided units into the one used by the install? If so then there might be no way to solve this issue then? The integration can only round when it gets the data and then HA converts it into local units which is where the difference lies.

EDIT: Thinking about it a bit if HA is the one that is doing the conversions then maybe for the entity it would make sense to have it removed on the entity and have it only affect sensors? Otherwise it will cause small discrepancies between the entity and the sensors.

@cloneofghosts cloneofghosts changed the title Turning on rounding causes wind speed discrepancy between weather card and sensors Turning on rounding causes discrepancy between weather card and sensors Feb 4, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Apr 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working Needs Review
Projects
2 participants