Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Precipitation Accumulation Units #122

Closed
cloneofghosts opened this issue Jul 4, 2023 · 3 comments
Closed

Fix Precipitation Accumulation Units #122

cloneofghosts opened this issue Jul 4, 2023 · 3 comments

Comments

@cloneofghosts
Copy link
Collaborator

As discussed in Pirate-Weather/pirateweather#72 the precipAccumulation units are always in cm whereas the HA integration displays them in mm.

I've only tested this using the weather entity and have not tested the sensors at all.
@alexander0042
Copy link
Collaborator

Thanks for the reminder- I just pushed the update live, so should see in your HACS feed soon!

@cloneofghosts
Copy link
Collaborator Author

Can confirm that the new update solves the issue. Though this will show the snowfall amount in mm instead of cm though once a liquid precipAccumulation gets added it will be fixed then.

@alexander0042
Copy link
Collaborator

Since this seems to be wrapped up, I'm going to close this for now! I've got the additional of a liquid precipitation on my list of enhancements, but I think it's a separate issue to this

@github-actions github-actions bot locked and limited conversation to collaborators Sep 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cloneofghosts @alexander0042