Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move TinyMCE into a separate module #815

Closed
121GWJolt opened this issue Sep 19, 2019 · 3 comments
Closed

Move TinyMCE into a separate module #815

121GWJolt opened this issue Sep 19, 2019 · 3 comments

Comments

@121GWJolt
Copy link
Contributor

121GWJolt commented Sep 19, 2019

TinyMCE currently requires a license to host it on anything other than an LGPLv3-compatible use case. Therefore, its inclusion in anything without the expensive self-hosting license has a legal risk attached to it. Potential alternatives include Trumbowyg and Summernote, both of which are MIT-licensed.

@tidyui
Copy link
Member

tidyui commented Sep 22, 2019

I have created a feature-branch for this and started working on it:

https://github.com/PiranhaCMS/piranha.core/tree/features/editor-restructuring

I have moved TinyMCE from the manager into its own package and also added a package for Summernote as an example. It's not complete, but I have added basic image library integration for the Summernote editor. The example MvcWeb uses the TinyMCE package and the RazorWeb example uses the Summernote package

@121GWJolt
Copy link
Contributor Author

Editor loads and I like the interface a lot. Media plugin loads for me too.

For saving I propose possibly hooking into this function or this function and changing the signature of the addInline method to have a callback for saving the model posted to it. Callback could pass one parameter containing the string value of Summernote's contents.

@tidyui tidyui closed this as completed Oct 10, 2019
@tidyui tidyui changed the title TinyMCE has licensing issues - Move it into a separate module and use a different default editor Move TinyMCE into a separate module Nov 16, 2019
@tidyui
Copy link
Member

tidyui commented Nov 16, 2019

I have gone through licensing terms and taken precautions. What this means is that I've added the correct "Powered by Tiny" link on all editors when active. As fas as LGPL this license does not prohibit usage in closed commercial software at all when components are used as a library. The only thing LGPL tries to control is that if you make changes or modifications to the library, these changes are also to be considered LGPL.

I am 100% sure that it's not a problem using LGPL components in closed source software as we in fact used this license for the old legacy version of Piranha for many years before switching to MIT.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants