Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MarkdownFields not saved on first click #392

Closed
tidyui opened this issue Oct 2, 2018 · 4 comments
Closed

MarkdownFields not saved on first click #392

tidyui opened this issue Oct 2, 2018 · 4 comments
Assignees
Milestone

Comments

@tidyui
Copy link
Member

tidyui commented Oct 2, 2018

There's a bug in the manager interface introduced with the Ajax save of the form causing content in MarkdownFields to not be processed on the first Save operation. Relates to #387

@mfronczyk
Copy link

Just tested it after upgrading to 5.2 and markdown fields are still not saved on the first click. It's actually a serious bug because editors might lose lots of work. Do you see it as well or do you need any help with debugging?

@tidyui
Copy link
Member Author

tidyui commented Oct 16, 2018

This has been tested and was resolved by adding the following line to the setup of the Markdown editors:

https://github.com/PiranhaCMS/piranha.core/blob/master/core/Piranha.Manager/assets/js/ui.js#L10

Are you sure you've done a "shift reload" of your manager resources so you don't have the old javascript file cached in the browser?

@mfronczyk
Copy link

mfronczyk commented Oct 16, 2018

Yes, clearing cache helped.

FYI, asp.net core lets you add version to the asset links (CSS, JS etc) automatically, so when they change, user browser doesn't use the cached version. Can be done like this:

<script src="~/dist/common.js" asp-append-version="true"></script>

By the way, region notes look very good. Thanks for adding it.

@tidyui
Copy link
Member Author

tidyui commented Oct 16, 2018

Awesome, and i didn’t know that, but I doubt it will work on the manager embedded resource in the current implementation. I’ll take a look at it when we update the manager for 6.0!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants