Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mobile Friendly Hamburger menu #302

Closed
CastleSoft opened this issue Jun 20, 2018 · 3 comments
Closed

Mobile Friendly Hamburger menu #302

CastleSoft opened this issue Jun 20, 2018 · 3 comments

Comments

@CastleSoft
Copy link

Change the menu to be mobile friendly / hamburger menu

@tidyui
Copy link
Member

tidyui commented Jun 20, 2018

Hi there! I need more information about what part of the system you're referring to

Best regards

Håkan

@CastleSoft
Copy link
Author

CastleSoft commented Jun 20, 2018

If I grab the latest version using:
Get the latest source code and get going:

git clone https://github.com/PiranhaCMS/piranha.core.git
cd piranha.core
dotnet restore
dotnet build
cd examples/CoreWeb
dotnet run
Build and update javascript/css assets
cd piranha.core/core/Piranha.Manager
npm install
bower install
cd ../../examples/CoreWeb
npm install
bower install

The default template doesn't appear to have reactive menus ?
The piranhacms.org site is ok.

I'm using it on .NET Core 2.1 (git clone/etc 5.1 daily/snapshot).

Could be the template is different to the:
dotnet new -i Piranha.BasicWeb.CSharp
dotnet new -i Piranha.Blog.CSharp

Versions ??

@tidyui
Copy link
Member

tidyui commented Jun 20, 2018

Aha.. Good call.. The example project is really just for manually testing functionality during development.

The template projects you mention Piranha.BasicWeb.CSharp & Piranha.Blog.CSharp both have responsive menus. Nevertheless it would be good to add it to the example.

Regards

@tidyui tidyui added this to the Version 5.2.2 milestone Oct 19, 2018
@tidyui tidyui added the request label Oct 31, 2018
@tidyui tidyui self-assigned this Nov 13, 2018
@tidyui tidyui closed this as completed in 2cbebb0 Nov 14, 2018
tidyui added a commit that referenced this issue Nov 14, 2018
Replaced example project with new from official website. Fixes #302
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants