Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specific Vue components give a compilation error on page-load. #1021

Closed
Streammz opened this issue Jan 31, 2020 · 1 comment
Closed

Specific Vue components give a compilation error on page-load. #1021

Streammz opened this issue Jan 31, 2020 · 1 comment
Assignees
Milestone

Comments

@Streammz
Copy link
Contributor

The QuoteBlock Vue component gives the following compilation error when loading the editor in the manager:

[Vue warn]: Error compiling template:

tag <p> has no matching end tag.

1  |  <div class='block-body' :class='{ empty: isEmpty }'>  <i class='fas fa-quote-right quote'></i>  <p class='lead' contenteditable='true' spellcheck='false' v-html='model.body.value' v-on:blur='onBlur'></pre></div>
   |                                                                                                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

found in

---> <QuoteBlock>
       <Root>

which can be fixed by changing the closing </pre> tag to a </p>, or the opening <p> to a <pre>, unsure which is required.


The HtmlColumnBlock Vue component gives the following compilation error when loading the editor in the manager:

[Vue warn]: Error compiling template:

duplicate attribute: class

1  |  <div class='block-body' class='row'>  <div class='col-md-6'>    <div :class='{ empty: isEmpty1 }'>      <div :id='uid + 1' contenteditable='true' spellcheck='false' v-html='column1' v-on:blur='onBlurCol1'></div>    </div>  </div>  <div class='col-md-6'>    <div :class='{ empty: isEmpty2 }'>      <div :id='uid + 2' contenteditable='true' spellcheck='false' v-html='column2' v-on:blur='onBlurCol2'></div>    </div>  </div></div>
   |                          ^^^^^^^^^^^

found in

---> <HtmlColumnBlock>
       <Root>

which can be fixed by removing the class='row' and appending row to the former class='block-body' component

@tidyui tidyui added this to the Version 8.1 milestone Jan 31, 2020
@Streammz
Copy link
Contributor Author

Streammz commented Jan 31, 2020

Additionally, I found this case as well after playing around with a bit:

The PageItem Vue component gives the following compilation error when loading the editor in the manager the media picker within the editor:

[Vue warn]: Error compiling template:

duplicate attribute: class

1  |  <li :data-id='item.id' class='dd-item' :class='{ expanded: item.isExpanded || item.items.length === 0 }'>  <div class='sitemap-item expanded'>    <div class='link'>      <span class='actions'>        <a v-if='item.items.length > 0 && item.isExpanded' v-on:click.prevent='toggleItem(item)' class='expand' href='#'><i class='fas fa-minus'></i></a>        <a v-if='item.items.length > 0 && !item.isExpanded' v-on:click.prevent='toggleItem(item)' class='expand' href='#'><i class='fas fa-plus'></i></a>      </span>      <a href='#' v-on:click.prevent='piranha.pagepicker.select(item)'>        {{ item.title }}      </a>    </div>    <div class='type d-none d-md-block'>      {{ item.typeName }}    </div>  </div>  <ol class='dd-list' v-if='item.items.length > 0' class='dd-list'>    <page-item v-for='child in item.items' v-bind:key='child.id' v-bind:item='child'>    </page-item>  </ol></li>
   |                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                          ^^^^^^^^^^^^^^^

found in

---> <PageItem>
       <Root>

which can be fixed by removing the duplicate class='dd-list' entry.

@tidyui tidyui self-assigned this Feb 3, 2020
@tidyui tidyui closed this as completed in dfadad1 Feb 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants