Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept Blue declare module statement does not get exported #494

Open
mschipperheyn opened this issue Aug 14, 2024 · 1 comment
Open

Accept Blue declare module statement does not get exported #494

mschipperheyn opened this issue Aug 14, 2024 · 1 comment

Comments

@mschipperheyn
Copy link
Collaborator

Which plugin/repository is the issue about?
accept-blue

Describe the bug
The declare module statement that is present in the accept-blue plugin does not seem to get picked up. This makes it problematic to access the customFields keys in service methods. Even importing the AcceptBlue Plugin as part of the plugin where you are accessing it, does not help. Also tried adding the node_modules/@Pinelab to tsConfig typeRoots. Perhaps there is something else I need to do?

To Reproduce
Steps to reproduce the behavior:

  1. Access the acceptBlueSubscriptionIds in a service method
  2. See error

Expected behavior
I would expect the declare module statements to be exported in a way that allows for it to get picked up by the type system in a convenient way or if not, for that to be documented

Screenshots
If applicable, add screenshots to help explain your problem.

Environment

  • NodeJS version
  • Vendure version: [e.g. 1.7.1]: 2.2.
  • Plugin version [e.g. 3.1.1]: 1.6.1
@martijnvdbrug
Copy link
Member

To be honest, I am not sure how to accomplish this. I did include the type declaration file in the package in this PR (v1.9.0), but couldn't get it to work in a consumer project yet...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants