Skip to content
This repository has been archived by the owner on Dec 26, 2022. It is now read-only.

✨ Partially implement MODAL_SUBMIT #485

Merged
merged 6 commits into from Jun 20, 2022
Merged

✨ Partially implement MODAL_SUBMIT #485

merged 6 commits into from Jun 20, 2022

Conversation

ghost
Copy link

@ghost ghost commented Jun 13, 2022

Changes

  • adds: MODAL interaction type (throws a NotImplementedError), missing SUPPRESS_EMBEDS flag (minor)
  • fixed: none
  • improvements: none

Check off the following

  • I have tested my changes with the current requirements
  • My Code follows the pep8 code style.

@codecov
Copy link

codecov bot commented Jun 13, 2022

Codecov Report

Merging #485 (e63bda3) into main (d414853) will decrease coverage by 0.00%.
The diff coverage is 60.00%.

@@            Coverage Diff             @@
##             main     #485      +/-   ##
==========================================
- Coverage   64.78%   64.78%   -0.01%     
==========================================
  Files         184      184              
  Lines        5989     5994       +5     
==========================================
+ Hits         3880     3883       +3     
- Misses       2109     2111       +2     
Impacted Files Coverage Δ
pincer/middleware/interaction_create.py 19.64% <0.00%> (-0.36%) ⬇️
pincer/objects/app/interaction_base.py 87.09% <100.00%> (+0.88%) ⬆️
pincer/objects/app/interaction_flags.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d414853...e63bda3. Read the comment docs.

@ghost
Copy link
Author

ghost commented Jun 13, 2022

💀 Nox is failing
UPD: I guess it's fine, I didn't edit the file that was failing.

@ghost
Copy link
Author

ghost commented Jun 13, 2022

oh and I accidentally pasted something lol

Copy link
Member

@Sigmanificient Sigmanificient left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess it will be nice to have something about it, even if this is a very partial implementation

@Sigmanificient Sigmanificient added the enhancement New feature or request label Jun 13, 2022
@ghost
Copy link
Author

ghost commented Jun 14, 2022

Maybe I will try to fully implement modals, but right now this can be merged, I think.

Copy link
Member

@Sigmanificient Sigmanificient left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Arthurdw Arthurdw merged commit 9215702 into Pincer-org:main Jun 20, 2022
@ghost
Copy link
Author

ghost commented Jun 21, 2022

next goal: fully implement modals (and autocomplete)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants