-
Notifications
You must be signed in to change notification settings - Fork 36
Conversation
Codecov Report
@@ Coverage Diff @@
## main #485 +/- ##
==========================================
- Coverage 64.78% 64.78% -0.01%
==========================================
Files 184 184
Lines 5989 5994 +5
==========================================
+ Hits 3880 3883 +3
- Misses 2109 2111 +2
Continue to review full report at Codecov.
|
💀 Nox is failing |
oh and I accidentally pasted something lol |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess it will be nice to have something about it, even if this is a very partial implementation
Maybe I will try to fully implement modals, but right now this can be merged, I think. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
next goal: fully implement modals (and autocomplete) |
Changes
adds
: MODAL interaction type (throws a NotImplementedError), missing SUPPRESS_EMBEDS flag (minor)fixed
: noneimprovements
: noneCheck off the following