-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature Request]: Add an option to show all videos from all playlists #66
Comments
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as duplicate.
This comment was marked as duplicate.
As playlists are allowed to contain the same video multiple times, this would just have to be a visual indicator, not a toggle button like the old favorites. Secondly as you can now create as many playlists as you want, I'm not sure how much benefit you would get from an icon that tells you it is added to a playlist, because you have no idea which one. While an all playlist does sound cool, a playlist that will inevitably be gigantic, will cause significant performance problems. See FreeTubeApp#4578 and FreeTubeApp#4597 for more information (TL;DR freezing for 14 seconds, on decently powerful hardware, on the watch page and any time the video changes while you are in that playlist). Therefore, anyone wanting to implement the all list, should definitely wait until there are workarounds in place for gigantic playlists, to avoid them causing performance problems (no that linked pull request doesn't solve it, solving it will require reworking the lazy loading system, which is a bigger change). There is a difference between a user creating a gigantic playlist and it lagging versus FreeTube auto-generating that gigantic playlist for you. If FreeTube does it, everyone would have the reasonable expectation that it should work well, so the all list should definitely wait. |
@absidue |
Note to self: Migrating this and the other issues later. The most important ones have already been migrated over. You dont have to take any action so dont migrate them yourself :) |
After internal discussion we decided to not migrate this over. |
Well I of course have to accept your decision, but even if you never want to implement this (which I think is 1. too early to say and 2. a big mistake (because of the multiple things that this could "solve"), it would be better to migrate this, so that people who want this feature can find this issue and see that you don't want to implement this, instead of opening new issues etc. |
Guidelines
Problem Description
There are multiple problems with the New playlists:
Proposed Solution
Having an "All" Playlist can be the first way to solve this.
It would:
Alternatives Considered
Issue Labels
improvement to existing feature
Additional Information
No response
The text was updated successfully, but these errors were encountered: