Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More efficient ternary array saving #3

Merged
merged 3 commits into from
Jul 22, 2024

Conversation

PhotonicGluon
Copy link
Owner

@PhotonicGluon PhotonicGluon commented Jul 22, 2024

Pull Request

Description

Made the saving algorithm for ternary arrays more memory efficient.

Type of change

Please delete options that are not relevant.

  • Performance improvement (enhancement of speed/memory use of the package)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@PhotonicGluon PhotonicGluon added the performance Performance-related things label Jul 22, 2024
@PhotonicGluon PhotonicGluon self-assigned this Jul 22, 2024
Copy link

codecov bot commented Jul 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (ad2e741) to head (5366d9c).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main        #3   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           33        33           
  Lines          871       895   +24     
=========================================
+ Hits           871       895   +24     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@PhotonicGluon PhotonicGluon merged commit 8fc09c3 into main Jul 22, 2024
25 checks passed
@PhotonicGluon PhotonicGluon deleted the more-efficient-ternary-array-saving branch July 22, 2024 04:40
PhotonicGluon added a commit that referenced this pull request Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
performance Performance-related things
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant