Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add name to the setup group #23

Open
tritemio opened this issue Aug 21, 2015 · 3 comments
Open

Add name to the setup group #23

tritemio opened this issue Aug 21, 2015 · 3 comments

Comments

@tritemio
Copy link
Contributor

I though it may be convenient to add a name (string) field to the setup group.

A name will make easier identifying measurements files from different setups, especially if they don't have a measurement_specs group.

@tritemio tritemio added this to the 0.5 milestone May 5, 2016
@tritemio
Copy link
Contributor Author

Maybe postpone or reject this?

@tritemio tritemio removed this from the 0.5 milestone Aug 28, 2017
@harripd
Copy link

harripd commented Jul 15, 2024

As v0.5 (maybe 0.6 now if we include FLIM) is putting more information about detectors etc. into the setup group, I think the is is a good idea, but I would rename it measurement_type to stay consistent with naming from measurement_specs.

@smXplorer
Copy link
Contributor

smXplorer commented Jul 16, 2024

There is already a measurement_type field in /photon_data/measurement_specs, see https://photon-hdf5.readthedocs.io/en/0.5.dev/phdata.html#measurement-specs

Looking at the description of the setup group, https://photon-hdf5.readthedocs.io/en/0.5.dev/phdata.html#measurement-specs, it is clear that a "name" for it would be something like "YH 2002G" or "Single-spot usALEX setup". This is not the same as a "measurement type", I believe (many different types of measurements can be performed on the same setup).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants