Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bh_print_sys_params() fails on python #45

Closed
dmopalmer opened this issue May 30, 2019 · 3 comments
Closed

bh_print_sys_params() fails on python #45

dmopalmer opened this issue May 30, 2019 · 3 comments

Comments

@dmopalmer
Copy link

bh_print_sys_params() in bhreader.py calls dict.iteritems() which is no longer in python3.

Since the dict in question is small, there is no reason not to use dict.items() instead.

This is true whether installed with conda -c conda-forge (v0.9) or pip (still v0.8.2 on pypi).

@tritemio
Copy link
Contributor

Thanks for the report. Would you mind sending a PR?

PS: dict.items() in python 3 is a generator like it was dict.iteritems() in python 2, so it is efficient.

@dmopalmer
Copy link
Author

The pull request #46 includes other features that it showed were necessary.

@tritemio
Copy link
Contributor

tritemio commented Jun 5, 2019

@dmopalmer, thanks for your contribution! It would be nice to also have a test to avoid these errors in the future.

Would you mind adding one to test_bhreader.py?
(the test there use the nose format, but you can use the simpler pytest format as in test_pqreader.py)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants