We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bh_print_sys_params() in bhreader.py calls dict.iteritems() which is no longer in python3.
bh_print_sys_params()
dict.iteritems()
Since the dict in question is small, there is no reason not to use dict.items() instead.
dict.items()
This is true whether installed with conda -c conda-forge (v0.9) or pip (still v0.8.2 on pypi).
conda -c conda-forge
pip
The text was updated successfully, but these errors were encountered:
Thanks for the report. Would you mind sending a PR?
PS: dict.items() in python 3 is a generator like it was dict.iteritems() in python 2, so it is efficient.
Sorry, something went wrong.
The pull request #46 includes other features that it showed were necessary.
@dmopalmer, thanks for your contribution! It would be nice to also have a test to avoid these errors in the future.
Would you mind adding one to test_bhreader.py? (the test there use the nose format, but you can use the simpler pytest format as in test_pqreader.py)
No branches or pull requests
bh_print_sys_params()
in bhreader.py callsdict.iteritems()
which is no longer in python3.Since the dict in question is small, there is no reason not to use
dict.items()
instead.This is true whether installed with
conda -c conda-forge
(v0.9) orpip
(still v0.8.2 on pypi).The text was updated successfully, but these errors were encountered: