-
-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
All tracks are missing trackSpecialSettings #87
Comments
Thanks for reporting! Is this broken since #65 or was this never working in this repo? |
@pehala Any opinion? |
The |
Thanks for the report. It indeed looks like it is missing from my new implementation as it wasn't properly documented, is it an optional row or a mandatory one? As you correctly point out the S row need to be implemented in all kinds of different places, since Track will be changed. @Nokkasiili Would you like to try to add that to your PR or should I edit it? Since tracks are now covered by tests you should get a good idea if the new implementation is correct from them and compile errors combined. |
Client will use default value if its missing |
Example from Darwin - Two Snakes:
S fttt12
Description of this string can be seen here:
playforia-minigolf/client/src/main/java/agolf/game/GameChatPanel.java
Line 116 in 85da3d2
The text was updated successfully, but these errors were encountered: