Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All tracks are missing trackSpecialSettings #87

Closed
Nokkasiili opened this issue Apr 2, 2021 · 8 comments
Closed

All tracks are missing trackSpecialSettings #87

Nokkasiili opened this issue Apr 2, 2021 · 8 comments

Comments

@Nokkasiili
Copy link

Nokkasiili commented Apr 2, 2021

Example from Darwin - Two Snakes:S fttt12
Description of this string can be seen here:

this.textAreaChat.addMessage("Special settings:");

@PhilippvK
Copy link
Owner

Thanks for reporting!

Is this broken since #65 or was this never working in this repo?

@Nokkasiili
Copy link
Author

@PhilippvK
Copy link
Owner

@pehala Any opinion?

@PhilippvK
Copy link
Owner

The S Row was not documented in https://github.com/PhilippvK/playforia-minigolf/blob/master/doc/FileFormat.md as far as I can tell.

@Nokkasiili
Copy link
Author

#88

@Nokkasiili
Copy link
Author

@pehala
Copy link
Collaborator

pehala commented Apr 2, 2021

Thanks for the report. It indeed looks like it is missing from my new implementation as it wasn't properly documented, is it an optional row or a mandatory one?

As you correctly point out the S row need to be implemented in all kinds of different places, since Track will be changed.

@Nokkasiili Would you like to try to add that to your PR or should I edit it? Since tracks are now covered by tests you should get a good idea if the new implementation is correct from them and compile errors combined.

@Nokkasiili
Copy link
Author

Nokkasiili commented Apr 2, 2021

private static final String defaultTrackSettings = "fttt14";

Client will use default value if its missing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants