Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to a better build system #35

Closed
pehala opened this issue Aug 25, 2020 · 2 comments · Fixed by #36
Closed

Migrate to a better build system #35

pehala opened this issue Aug 25, 2020 · 2 comments · Fixed by #36

Comments

@pehala
Copy link
Collaborator

pehala commented Aug 25, 2020

While the current Ant system works, I think it would be a good idea to migrate to a better build system like Maven, which would enable things like proper dependency management and not depend on hardcoded jars stored at GitHub and also compiling all artefacts with one command from the root directory.

@pehala
Copy link
Collaborator Author

pehala commented Aug 25, 2020

Hey @PhilippvK, I wanted to ask if this is something you would like to see. I would code it myself and then submit PR but I wanted to discuss it beforehand.

@PhilippvK
Copy link
Owner

Hello and thanks for your proposal.

Getting rid of Ant would be very great in my opinion. I unfortunately never had the time to do a migration by myself.

I would appreciate if you try to build the project using maven and am looking forward to a PR.

In my opinion it is very important that the Travis CI Setup stays functional. (At least the generation of JAR files and Releases) Optionally it would be great if the building of windows/macos installers (see distributions branch) would still be possible (preferably also over CI)

I am happy to help with the CI/Installer part if I csn find time but to make things easier, I would recommend you to take the build_dist.xml Antfile from the mentioned branch as a base for the migration.

@pehala pehala mentioned this issue Aug 26, 2020
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants