Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to integrate into LinearSolve.jl #2

Closed
PetrKryslUCSD opened this issue Jun 9, 2022 · 8 comments
Closed

How to integrate into LinearSolve.jl #2

PetrKryslUCSD opened this issue Jun 9, 2022 · 8 comments

Comments

@PetrKryslUCSD
Copy link
Owner

https://github.com/SciML/LinearSolve.jl

@rayegun
Copy link

rayegun commented Dec 12, 2022

Can we add a constructor that for Problem that takes A, x and b (Ax = b) Vectors as input?

@j-fu
Copy link
Contributor

j-fu commented Dec 12, 2022

#9 could help with that.

@rayegun
Copy link

rayegun commented Dec 12, 2022

Okay great.

Now is there a way to pass a new vector of values for re-solving? After the symbolic factorization.

I see that solve! might be able to do this, but I'm not sure how to pass the new value vector in (we assume the pattern is the same of course).

@j-fu
Copy link
Contributor

j-fu commented Dec 12, 2022

Here is what I did for ExtendableSparse.jl:
https://github.com/j-fu/ExtendableSparse.jl/blob/master/src/SparspakCSCInterface.jl

(BTW want to make that compatible to LinearSolve, but need to find the time...)

@PetrKryslUCSD
Copy link
Owner Author

Okay great.

Now is there a way to pass a new vector of values for re-solving? After the symbolic factorization.

I see that solve! might be able to do this, but I'm not sure how to pass the new value vector in (we assume the pattern is the same of course).

If you'd like to use multiple right hand sides, use

zerorhs!(p)
infullrhs!(p, rhs)

This will be in the version 0.3.2 (just registered).

@PetrKryslUCSD
Copy link
Owner Author

I agree that integration into LinearSolve is probably the way to go to provide a really simple interface.

@rayegun
Copy link

rayegun commented Dec 18, 2022

@j-fu do you mind if I add that module from ExtendableSparse.jl to LinearSolve.jl?

@j-fu
Copy link
Contributor

j-fu commented Jan 22, 2023

Since 0.33.1, Sparspak appears to be fully functional with LinearSolve.
It is also the default solver for Non-GPL builds and general number types.

So I guess we can close this issue...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants