You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It triggers both specified warnings, because generated FruitsIter does implement neither Debug nor Copy. The latter is understandable (copyable iterators are quite a footgun, to be honest), the former might probably be adjusted, but maybe this implementation being missing is reasonable too.
What's important, however, is that the user has no way to silence these warnings short of allowing them for the whole module, since there's no way to place the attribute on the derive-generated structure. Probably strum wants to allow these (and possibly others) lints itself?
The text was updated successfully, but these errors were encountered:
Thanks for point this out. Added the linked PR to address the issue. Ideally, the iter should implement debug, but agree that Copy is probably a footgun. Unfortunately adding a Debug impl could be a breaking change b/c someone may have manually implemented it so I'll save that change for a larger version update. We can fix this lint though with a minor change and allowing these 2 lints
Consider the following code (from this SO question):
It triggers both specified warnings, because generated
FruitsIter
does implement neitherDebug
norCopy
. The latter is understandable (copyable iterators are quite a footgun, to be honest), the former might probably be adjusted, but maybe this implementation being missing is reasonable too.What's important, however, is that the user has no way to silence these warnings short of
allow
ing them for the whole module, since there's no way to place the attribute on thederive
-generated structure. Probablystrum
wants toallow
these (and possibly others) lints itself?The text was updated successfully, but these errors were encountered: