Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Signup flow succeeds with "You are registered", despite sendMail failure #6

Open
neoneye opened this issue May 19, 2018 · 0 comments
Open

Comments

@neoneye
Copy link

neoneye commented May 19, 2018

When trying to register a new user, then I'm getting this error in the console:

email.send error: Error(code: 7, description: "Couldn\'t connect to server", response: PerfectCURL.CURLResponse)

The "You are registered" message is coming from the LocalAuthWebHandlers.registerPost() function. This function does check for errors, but fails to detect that the email couldn't be sent.

Solution

Modify the Account.register() function so it checks of the return value from the Utility.sendMail() function.

Modify the Utility. sendMail() catch block, so it doesn't discards the smtp errors. Perhaps use the smtp code from the mysql repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant