Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compatibility with the new return system #281

Merged
merged 5 commits into from
Apr 10, 2023
Merged

Compatibility with the new return system #281

merged 5 commits into from
Apr 10, 2023

Conversation

rmoyard
Copy link
Contributor

@rmoyard rmoyard commented Apr 10, 2023 •
edited
Loading

  1. Add the new return system
  2. The legacy system is still accessible

@codecov
Copy link

codecov bot commented Apr 10, 2023 •
edited
Loading

Codecov Report

Merging #281 (ca6481b) into master (5d67f6e) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #281   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            6         6           
  Lines          296       302    +6     
=========================================
+ Hits           296       302    +6
Impacted Files Coverage Δ
pennylane_qiskit/qiskit_device.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@rmoyard
Copy link
Contributor Author

rmoyard commented Apr 10, 2023

[sc-35005]

@rmoyard rmoyard requested review from mudit2812 and albi3ro April 10, 2023 14:33
albi3ro
albi3ro approved these changes Apr 10, 2023
View reviewed changes
Copy link
Contributor

@albi3ro albi3ro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a suggestion about the TODO comment, but its not particularly important.

Looks good to me 👍

mudit2812
mudit2812 reviewed Apr 10, 2023
View reviewed changes
Copy link
Contributor

@mudit2812 mudit2812 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good Romain! Please add a changelog entry. Do we need to pin the required version of pennylane in requirements.txt since the private functions for the new return types were renamed?

@rmoyard rmoyard merged commit 9f74678 into master Apr 10, 2023
@rmoyard rmoyard deleted the new_return branch April 10, 2023 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mudit2812 mudit2812 mudit2812 left review comments

@albi3ro albi3ro albi3ro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rmoyard @albi3ro @mudit2812