Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define returns_state in capabilities #220

Merged
merged 4 commits into from
Jun 8, 2022
Merged

Conversation

antalszava
Copy link
Contributor

@antalszava antalszava commented Jun 8, 2022

The state backend devices are capable of returning the state, yet they don't have the returns_state=True entry in the capabilities dictionary of the device (see the explanation of capabilities here).

@antalszava antalszava changed the title Define state method and returns_state=True in capabilities Define returns_state in capabilities Jun 8, 2022
@antalszava antalszava requested a review from rmoyard June 8, 2022 21:28
@codecov
Copy link

codecov bot commented Jun 8, 2022

Codecov Report

Merging #220 (1fa563f) into master (9495331) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #220   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            6         6           
  Lines          290       291    +1     
=========================================
+ Hits           290       291    +1     
Impacted Files Coverage Δ
pennylane_qiskit/qiskit_device.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9495331...1fa563f. Read the comment docs.

Copy link
Contributor

@rmoyard rmoyard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @antalszava 💯 Don't forget to add your name in the changelog

@antalszava antalszava merged commit d5223a5 into master Jun 8, 2022
@antalszava antalszava deleted the fix_returns_state branch June 8, 2022 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants