Qiskit v0.20 #101
Qiskit v0.20 #101
Conversation
Codecov Report
@@ Coverage Diff @@
## master #101 +/- ##
=======================================
Coverage 99.23% 99.23%
=======================================
Files 7 7
Lines 263 263
=======================================
Hits 261 261
Misses 2 2 Continue to review full report at Codecov.
|
| @@ -812,16 +806,13 @@ def test_qasm_from_file(self, tmpdir, recorder): | |||
| assert recorder.queue[5].parameters == [] | |||
| assert recorder.queue[5].wires == Wires([3]) | |||
|
|
|||
| assert len(record) == 11 | |||
| assert len(record) == 5 | |||
There was a problem hiding this comment.
As far as I recall that the CU1Gate was added at the time because it was the only gate that lacked the to_matrix method. Hence it couldn't be converted.
There was a problem hiding this comment.
Nice! So it turns out the test was failing because the converter now works automatically for the CU1 gate 😆
There was a problem hiding this comment.
I think this looks fine @antalszava. Not exactly sure how removing the CU1Gate impacts the tests, but it looks alright, and the tests seem to pass fine! 😄
There was a problem hiding this comment.
This is great, thanks @antalszava!
@thisac, I believe the CU1 gate is being automatically converted into a qml.QubitUnitary gate, via the qiskit to_matrix() method (which it previously didn't support, so a warning would be raised instead). As a result, the number of operations on the recorder increased, while the number of warning messages on the record decreased.
| @@ -812,16 +806,13 @@ def test_qasm_from_file(self, tmpdir, recorder): | |||
| assert recorder.queue[5].parameters == [] | |||
| assert recorder.queue[5].wires == Wires([3]) | |||
|
|
|||
| assert len(record) == 11 | |||
| assert len(record) == 5 | |||
There was a problem hiding this comment.
Nice! So it turns out the test was failing because the converter now works automatically for the CU1 gate 😆
| with monkeypatch.context() as m: | ||
| m.delenv("IBMQX_TOKEN", raising=False) | ||
| IBMQDevice(wires=1) |
CU1gate in a test which tests for unsupported instructions. TheCU1gate is now supported with Qiskit v0.20 and is converted using itsto_matrixmethod andQubitUnitary.IBMQX_TOKENenvironment variable in thetest_account_errorcase (env var might be defined making the test fail)requirements.txtandsetup.py