Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add acq-<label> to filename of html report #835

Open
jhauneuro opened this issue Oct 24, 2024 · 8 comments
Open

Add acq-<label> to filename of html report #835

jhauneuro opened this issue Oct 24, 2024 · 8 comments
Labels
enhancement New feature or request

Comments

@jhauneuro
Copy link

jhauneuro commented Oct 24, 2024

Summary

I have multiple dwi images in my scan session. When I preprocess these data the sub-X.html report gets overwritten in the output sub-X folder.

Additional details

The benefit is to preserve separate html reports for each preprocessed dwi in a scan session.

Next steps

Adding acq- to the name of the html report could help resolve this issue and prevent overwriting. Adding ses- will also be helpful for datasets with multiple sessions.

@jhauneuro jhauneuro added the enhancement New feature or request label Oct 24, 2024
@jhauneuro jhauneuro changed the title Add acq-<label> to html report Add acq-<label> to filename of html report Oct 24, 2024
@tsalo
Copy link
Member

tsalo commented Oct 28, 2024

That doesn't really fit with the naming convention of other preps. Can you expand on your workflow? Do you run QSIPrep multiple times?

@jhauneuro
Copy link
Author

Yes, I am running qsiprep multiple times for a subject because I have dwi scans with different spatial resolutions within a session requiring a different --output-resolution in the qsiprep command.

@jhauneuro
Copy link
Author

I can also rename the html report afterwards, I've found that works.

@mattcieslak
Copy link
Collaborator

oh, that's unfortunate. Maybe the best approach would be to implement --output-resolution auto

@tsalo
Copy link
Member

tsalo commented Oct 28, 2024

The HTML report is generated from scratch each time you run QSIPrep, so it should include sections corresponding to the different acquisitions. If it's not doing that, then I think we have a bug.

We have talked about having native-min and native-max options for output resolution in the past.

@jhauneuro
Copy link
Author

oh, that's unfortunate. Maybe the best approach would be to implement --output-resolution auto

Yes, this would be perfect for my use case. I generally set it to the min native spatial res dimension of my data so I like the idea of native-min and native-max options!

I also have a different eddy config file for each dwi sequence to set the mporder parameter. I calculate that manually as per FSL guidelines (N/4 to N/2; N=number of excitations per volume), which requires knowing the number of slices and multiband factor.

@mattcieslak
Copy link
Collaborator

I also have a different eddy config file for each dwi sequence to set the mporder parameter. I calculate that manually as per FSL guidelines (N/4 to N/2; N=number of excitations per volume), which requires knowing the number of slices and multiband factor.

This sounds like something that should also be automatically filled in based in BIDS. Are you currently doing anything else manually?

@jhauneuro
Copy link
Author

Just those two parameters. If we can provide options to automatically set them that would be amazing. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants