Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add command to replace IntendedFor fields with B0FieldSource/B0FieldIdentifier #274

Open
tsalo opened this issue Dec 4, 2023 · 6 comments
Assignees
Labels
enhancement New feature or request

Comments

@tsalo
Copy link
Member

tsalo commented Dec 4, 2023

SDCFlows doesn't seem to work on phase-difference field maps with the IntendedFor field, but it does work on B0FieldSource/B0FieldIdentifier fields. EPI distortion correction seems to work with either one.

I'm not sure how to correctly divvy up field maps if multiple ones are intended for the same distorted files.

Per Matt, check for shim settings.

@tsalo tsalo added the enhancement New feature or request label Dec 4, 2023
@mattcieslak
Copy link
Contributor

Just to double-check, which of the phasediff files had the IntendedFor in its sidecar? both the phasediff and the magnitude images?

@tsalo
Copy link
Member Author

tsalo commented Dec 4, 2023

I just checked and it's actually a separate-phase maps setup, but the IntendedFor is present in all four files.

@mattcieslak
Copy link
Contributor

This might be an sdcflows bug then

@tsalo
Copy link
Member Author

tsalo commented Dec 4, 2023

@mattcieslak you're right. It looks like SDCFlows identifies B0Field* fmaps first, and it ignores the session entity when it does it, so having even one B0Field*-type fmap in the BIDS dataset will mean that IntendedFor ones won't be identified.

@tsalo
Copy link
Member Author

tsalo commented Dec 4, 2023

Still, given that there's this weird limitation in SDCFlows, it would definitely be useful to have a command that ensures that we use consistent field map labeling in a dataset.

@tsalo
Copy link
Member Author

tsalo commented Jan 31, 2024

Plus it would generally be a good idea to include tools to basically update BIDS datasets to use newer features. Here are a few examples:

  • IntendedFor --> B0Field*
  • Relative paths --> BIDS URIs
  • rec-magnitude/phase from old versions of Heudiconv --> part-mag/phase
  • Deprecated suffixes phase, FLASH, PD, and T2star

@tsalo tsalo self-assigned this Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants