Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show Docker icon for files with Dockerfile extension #652

Merged
merged 2 commits into from
May 2, 2022

Conversation

TeamTamoad
Copy link
Contributor

@TeamTamoad TeamTamoad commented May 1, 2022

There are some situation that developers need to put multiple Dockerfiles in the same directory. This is one of the recommended naming convention.

Before
image

After
image


TODO

  • Use cargo fmt
  • Add necessary tests
  • Add changelog entry
  • Update default config/theme in README (if applicable)
  • Update man page at lsd/doc/lsd.md (if applicable)

@TeamTamoad TeamTamoad requested review from meain and Peltoche as code owners May 1, 2022 08:08
@codecov-commenter
Copy link

codecov-commenter commented May 2, 2022

Codecov Report

Merging #652 (6551eb6) into master (46f596f) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #652   +/-   ##
=======================================
  Coverage   86.56%   86.56%           
=======================================
  Files          40       40           
  Lines        4377     4378    +1     
=======================================
+ Hits         3789     3790    +1     
  Misses        588      588           
Impacted Files Coverage Δ
src/icon.rs 97.73% <100.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 46f596f...6551eb6. Read the comment docs.

@meain
Copy link
Member

meain commented May 2, 2022

Hey, thanks for the PR. I just merged in another PR which seems to create a conflict in the CHANGELOG file. Could you push your changes rebased on top of current master.

@TeamTamoad
Copy link
Contributor Author

Hey, thanks for the PR. I just merged in another PR which seems to create a conflict in the CHANGELOG file. Could you push your changes rebased on top of current master.

Done!

@meain meain merged commit 23a11de into lsd-rs:master May 2, 2022
@TeamTamoad TeamTamoad deleted the dockerfile-icon branch June 13, 2022 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants