Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade proto compilation script to work with newest version of buf #171

Open
philipjames44 opened this issue Aug 29, 2022 · 0 comments
Open
Labels
bug Something isn't working enhancement New feature or request help wanted Extra attention is needed

Comments

@philipjames44
Copy link
Collaborator

philipjames44 commented Aug 29, 2022

Buf version 0.48.2 (https://github.com/bufbuild/buf/releases/tag/v0.48.2) is the highest confirmed working version to compile proto files using ./scripts/protocgen.sh; at the moment, to install this version a manual buf installation from source is required.

As of writing this ticket, buf is currently on release 1.7.0 so we are considerably behind the latest release.

The goal of this ticket should be to investigate if we actually want buf as a depencency, and either update the script to work with the most recent version of buf, or remove it entirely from the script.

Note: Regardless of buf version changes, the protoc-gen-grpc-gateway plugin will also have to be upgraded to v2. Our current script assumes v1 which is out of date and must be force installed.

@philipjames44 philipjames44 added bug Something isn't working enhancement New feature or request help wanted Extra attention is needed labels Aug 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant