Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: missing supply for add-genesis-account #498

Merged
merged 4 commits into from
Mar 22, 2023
Merged

Conversation

mmsqe
Copy link
Contributor

@mmsqe mmsqe commented Mar 20, 2023

No description provided.

@mmsqe mmsqe marked this pull request as ready for review March 20, 2023 15:31
@mmsqe mmsqe requested review from jackzampolin and mvid as code owners March 20, 2023 15:31
Copy link
Member

@cbrit cbrit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! A few comments and question!

module/cmd/gravity/cmd/genaccounts_test.go Outdated Show resolved Hide resolved
module/cmd/gravity/cmd/genaccounts_test.go Show resolved Hide resolved
module/cmd/gravity/cmd/genaccounts.go Show resolved Hide resolved
@codecov-commenter
Copy link

Codecov Report

Merging #498 (50a797c) into main (3d7b512) will increase coverage by 1.06%.
The diff coverage is 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #498      +/-   ##
==========================================
+ Coverage   28.69%   29.75%   +1.06%     
==========================================
  Files          47       47              
  Lines        6555     6580      +25     
==========================================
+ Hits         1881     1958      +77     
+ Misses       4527     4463      -64     
- Partials      147      159      +12     
Impacted Files Coverage Δ
module/cmd/gravity/cmd/genaccounts.go 61.60% <100.00%> (+61.60%) ⬆️

... and 1 file with indirect coverage changes

Copy link
Member

@cbrit cbrit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cbrit cbrit merged commit 9b457ae into PeggyJV:main Mar 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants