Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for "NO-HASH" when signing with ECDSA #83

Open
nirfireblocks opened this issue Jan 31, 2024 · 0 comments
Open

Adding support for "NO-HASH" when signing with ECDSA #83

nirfireblocks opened this issue Jan 31, 2024 · 0 comments

Comments

@nirfireblocks
Copy link

Hi @microshine,

We ran into a use case where the data to be signed via ECDSA is already hashed, and should not be hashed again. As it wasn't available, I added the option to sign via ECDSA with the hash algorithm "NO-HASH". I created two pull requests:
node-webcrypto-p11: #82
webcrypto-core: PeculiarVentures/webcrypto-core#64

These are tiny PRs, I tested them and they worked great.

Could you please merge them into the master branch?

Thanks,
Nir

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant