Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

universal modules should be supported in ngc when reading metadata #1

Closed
PatrickJS opened this issue Mar 13, 2017 · 2 comments
Closed

universal modules should be supported in ngc when reading metadata #1

PatrickJS opened this issue Mar 13, 2017 · 2 comments

Comments

@PatrickJS
Copy link
Owner

PatrickJS commented Mar 13, 2017 •
edited
Loading

https://github.com/gdi2290/ng4-universal-demo/blob/master/src/app/app.module.ts#L8

remove the /browser path to see the error ERROR in TransferHttpModule is not an NgModule

ngc is having problems resolving the metadata for modules that use browser/main fields. In the app this works for type in the constructor so it's confusing to the developer that doesn't realize the magic going on with metadata
@PatrickJS
Copy link
Owner Author

most likely caused by microsoft/TypeScript#7753 since ngc uses typescript type definition resolving logic to generate/read metadata

@PatrickJS
Copy link
Owner Author

can't do anything about this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@PatrickJS