From 824552c9138f141cdd01f1bb620dd3c2fa5b90bf Mon Sep 17 00:00:00 2001 From: Ira <61128114+stackaccount1@users.noreply.github.com> Date: Thu, 18 Aug 2022 14:10:03 -0400 Subject: [PATCH 1/2] Update README.md add hardhat-deploy install command for easier grab and install while completing tutorial --- README.md | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/README.md b/README.md index 2743b135..72e60c5a 100644 --- a/README.md +++ b/README.md @@ -62,14 +62,22 @@ If you can't or don't want to run and install locally, you can work with this re [![Open in Gitpod](https://gitpod.io/button/open-in-gitpod.svg)](https://gitpod.io/#github.com/PatrickAlphaC/hardhat-fund-me-fcc) +# Installing Hardhat Deploy + +To install hardhat deploy run the command: +``` +npm install --save-dev @nomiclabs/hardhat-ethers@npm:hardhat-deploy-ethers ethers +``` +[hardhat-deploy repo](https://github.com/wighawag/hardhat-deploy#installation) + # Usage Deploy: - ``` yarn hardhat deploy ``` + ## Testing ``` From 6c258fcdcd3aff29ed4947f5d9edc0b690a7f549 Mon Sep 17 00:00:00 2001 From: Ira <61128114+stackaccount1@users.noreply.github.com> Date: Thu, 18 Aug 2022 23:00:58 -0400 Subject: [PATCH 2/2] Update FundMe.test.js Change line 126 due to error: AssertionError: Expected transaction to be reverted, but other exception was thrown: RangeError: Maximum call stack size exceeded // Make a getter for storage variables ``` await expect(fundMe.getFunder(0)).to.be.reverted ``` Changed to ``` await expect(fundMe.getFunder({ value: 0 })).to.be.reverted ``` This worked for me if this is correct syntax, it probably should be changed --- test/unit/FundMe.test.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/unit/FundMe.test.js b/test/unit/FundMe.test.js index 017fee13..28737df3 100644 --- a/test/unit/FundMe.test.js +++ b/test/unit/FundMe.test.js @@ -123,7 +123,7 @@ const { developmentChains } = require("../../helper-hardhat-config") endingDeployerBalance.add(withdrawGasCost).toString() ) // Make a getter for storage variables - await expect(fundMe.getFunder(0)).to.be.reverted + await expect(fundMe.getFunder({ value: 0 })).to.be.reverted for (i = 1; i < 6; i++) { assert.equal(