Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Feature Request: Pin notes #534

Closed
Varsha-Kulkarni opened this issue Oct 2, 2022 · 4 comments · Fixed by #539, #558 or #559
Closed

[Android] Feature Request: Pin notes #534

Varsha-Kulkarni opened this issue Oct 2, 2022 · 4 comments · Fixed by #539, #558 or #559
Assignees
Labels
enhancement New feature or request hacktoberfest For partifipating in Hacktoberfest noty-android
Milestone

Comments

@Varsha-Kulkarni
Copy link
Contributor

Pin notes so that they will be added to priority spot, at the top for easy access, similar to Google Keep.

We can further discuss about UI changes and state handling required to show these pinned notes.

@Varsha-Kulkarni
Copy link
Contributor Author

Please assign this to me, Thanks.

@PatilShreyas
Copy link
Owner

This feature sounds cool to me, assigning it to you

@PatilShreyas PatilShreyas added hacktoberfest For partifipating in Hacktoberfest noty-api noty-android enhancement New feature or request labels Oct 2, 2022
@Varsha-Kulkarni
Copy link
Contributor Author

Varsha-Kulkarni commented Oct 2, 2022

Found another issue while navigating to Note Detail screen, progressDialog shows up when state is Loading. That shows up as kind of jerk (white square) while navigating. I have added pin icon for detail screen as part of options menu (screenshots attached).
OnCreateOptionsMenu gets called once before and after note state updates. The icon which is updated based on isPinned state is rerendered because of the second call and goes to default icon. When I removed the showProgressDialog while Loading, it all updates and works fine. Please let me know whether I should create another issue for this or fix it as part of this feature.
Screenshot_20221002-225849_Noty Screenshot_20221002-225900_Noty
Screenshot_20221002-225855_Noty

@PatilShreyas
Copy link
Owner

Good finding 👍. This can be part of this issue itself.

@PatilShreyas PatilShreyas modified the milestones: v2.0.0, v2.1.0 Oct 5, 2022
@PatilShreyas PatilShreyas changed the title Feature Request: Pin notes [Android] Feature Request: Pin notes Oct 5, 2022
@PatilShreyas PatilShreyas moved this to Review in progress in NotyKT Oct 5, 2022
@PatilShreyas PatilShreyas moved this from Review in progress to Reviewer approved in NotyKT Oct 7, 2022
@PatilShreyas PatilShreyas moved this from Reviewer approved to Done in NotyKT Oct 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment