Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ModBuildConfig 4.3.0: ContentPacks IgnoreModFilePatterns attribute not working as expected #965

Open
b-b-blueberry opened this issue Oct 10, 2024 · 0 comments

Comments

@b-b-blueberry
Copy link

b-b-blueberry commented Oct 10, 2024

Expected:
Using ItemGroup ContentPacks, including a CP project in the same solution would copy both C# and CP components to a parent folder when the C# project is built, ignoring paths and patterns given in the IgnoreModFilePatterns and IgnoreModFilePaths attributes on ContentPacks.

Issue:
Solution projects included in ContentPacks will deploy all files and folders to the output folder, regardless of attributes given in the main project ContentPacks or the CP project PropertyGroup.

Reproduce:

  1. Create solution including multiple projects buildable with ModBuildConfig,
  2. Add ItemGroup ContentPacks to the main project, including any other projects,
  3. Build main project, bundling all files from included projects.

Attachments:
Minimum repro solution with basic C# and CP projects
Solution.zip

Other info:
Possible cause?

// parse ignore patterns
string[] ignoreFilePaths = this.GetCustomIgnoreFilePaths(this.IgnoreModFilePatterns).ToArray();
Regex[] ignoreFilePatterns = this.GetCustomIgnorePatterns(this.IgnoreModFilePaths).ToArray();

// get options
ignoreFilePaths = this.GetCustomIgnoreFilePaths(item.GetMetadata("IgnoreModFilePatterns")).ToArray();
ignoreFilePatterns = this.GetCustomIgnorePatterns(this.IgnoreModFilePaths).ToArray();

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant