Allow next middleware handle error in handleParseErrors #2260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
This seems to be a good idea! Thanks for your contribution |
rsouzas
pushed a commit
to back4app/parse-server
that referenced
this pull request
Mar 15, 2017
rsouzas
pushed a commit
to back4app/parse-server
that referenced
this pull request
Mar 16, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think it's a good idea to allow next middlewares to handle errors. Fox example I would love to report errors from parse-server to (for example) Rollbar. But unfortunately they're handled in
handleParseErrorsfunction already (I think'Uncaught internal server error.'message is unfortunate in this case...). This would allow me to use another error handler in my application. It won't change a thing in parse-server logic and I (and others) would be pleased to have it.